[Source Gen] Create JSON directly instead of using anonymous type #1191
+141
−459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satvu
changed the title
|
Pushing out initial prototype quickly for cold-start testing, but to do:
|
7 tasks
fabiocav
reviewed
Nov 21, 2022
sdk/Sdk.Generators/FunctionMetadataProviderGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
jviau
reviewed
Nov 23, 2022
sdk/Sdk.Generators/FunctionMetadataProviderGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
satvu
commented
Nov 28, 2022
| @@ -21,6 +21,6 @@ internal class GeneratorFunctionMetadata | |||
|
|
|||
| public IDictionary<string, object> Properties { get; set; } = new Dictionary<string, object>(); | |||
|
|
|||
| public IList<IDictionary<string, string>> RawBindings { get; set; } = new List<IDictionary<string, string>>(); // List of <propertyName, propertyValue> bindings. | |||
| public IList<IDictionary<string, object>> RawBindings { get; set; } = new List<IDictionary<string, object>>(); // List of <propertyName, propertyValue> bindings. | |||
There was a problem hiding this comment.
string -> object change is due to switching to JSON serialization. Previously, arrays were stored as a string that would be written right to the generated file, but now we need the actual array object.
satvu
commented
Nov 28, 2022
| </PropertyGroup> | ||
|
|
||
| <Import Project="..\..\build\Common.props" /> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="5.0.0" PrivateAssets="all" GeneratePathProperty="true" /> |
There was a problem hiding this comment.
This package and the one below it are dependencies of System.Text.Json - we have to include these explicitly.
satvu
commented
Nov 28, 2022
7 tasks
test/Sdk.Generator.Tests/FunctionMetadataProviderGeneratorTests/ExtensionsTests.cs
Outdated
Show resolved
Hide resolved
fabiocav
reviewed
Dec 1, 2022
sdk/Sdk.Generators/FunctionMetadataProviderGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
jviau
approved these changes
Dec 1, 2022
| <ItemGroup> | ||
| <!-- Package the generator in the analyzer directory of the nuget package --> | ||
| <None Include="$(OutputPath)\$(AssemblyName).dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" /> | ||
|
|
||
| <None Include="$(PKGSystem_Text_Json)\lib\netstandard2.0\*.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" /> |
There was a problem hiding this comment.
I can see you are using this package, but where/why are the other two needed? Are they dependencies of STJ?
There was a problem hiding this comment.
Yes they're dependencies of STJ and they won't get loaded with STJ ... had to add each package associated with a "couldn't find file or assembly" until the generator built successfully.
fabiocav
approved these changes
Dec 1, 2022
|
/check-enforcer evaluate |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #1188
Pull request checklist
release_notes.mdAdditional information
Additional PR information