Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen azureml-dataprep requirements to cloudpickle<=2.0.0 #1637

Closed
thomasfrederikhoeck opened this issue Nov 18, 2021 · 10 comments
Closed

Loosen azureml-dataprep requirements to cloudpickle<=2.0.0 #1637

thomasfrederikhoeck opened this issue Nov 18, 2021 · 10 comments
Assignees

Comments

@thomasfrederikhoeck
Copy link

azureml-dataprep (which is a depedency for azureml-dataset-runtime) has requirement cloudpickle<2.0.0 and >=1.1.0. However there is to my knowledage no breaking features going from cloudpickle==1.6.0 to cloudpickle==2.0.0. cloudpickle==2.0.0 introduces some very effective tools for serializing helper scripts which is very helful when working with azureml. So azureml-dataprep should allow cloudpickle==2.0.0

Intro to new cloudpickle:
https://github.com/cloudpipe/cloudpickle#overriding-pickles-serialization-mechanism-for-importable-constructs

PR:

cloudpipe/cloudpickle#417


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@YutongTie-MSFT
Copy link

@harneetvirk Hello Harneet, could you please review the PR and see if we can merge it? Thanks.

@yikei
Copy link

yikei commented Nov 19, 2021

@thomasfrederikhoeck - Thank you for your feedback here and also sending us an email! I am part of the team maintaining azureml-dataprep.

We included version upper bounds to the packages we depend on to avoid automatically taking in new major versions that might have breaking changes. We will look into loosening the upper bound of cloudpickle and get back to you about this.

@thomasfrederikhoeck
Copy link
Author

That makes a lot of sense and is probably a good default behavior @yikei . I will be looking forward to it :-)

@YutongTie-MSFT
Copy link

@thomasfrederikhoeck Hello Thomas, is that possible for you to accept the answer in Q&A forum since this issue has been good handle here by yikei?
https://docs.microsoft.com/en-us/answers/questions/632441/index.html

Thanks a lot!

@thomasfrederikhoeck
Copy link
Author

@YutongTie-MSFT done :-)

@yikei
Copy link

yikei commented Dec 1, 2021

@thomasfrederikhoeck Quick update - we are targeting to loosen the upper bound of cloudpickle and have the change shipped by mid January. It should be released as azureml-dataprep 2.26, which will be used by AzureML SDK 1.38. Thanks!

@thomasfrederikhoeck
Copy link
Author

@yikei wonderful! Many thanks.

@yikei
Copy link

yikei commented Jan 11, 2022

To give an update, we released azureml-dataprep 2.26 already. Once azureml sdk 1.38 releases (scheduled for 1/24/2022), it will start picking up azureml-dataprep 2.26. (If you use compute instances, it may take a few extra days for the image to get updated to use the newest versions.)
Or, you may try upgrading dataprep manually if you need it urgently. Thanks!

@thomasfrederikhoeck
Copy link
Author

@yikei sounds good! I will close the ticket as it relates to azureml-dataprep. Thank you for fixing. As site-note: when I went to https://pypi.org/project/azureml-dataprep/2.26.0/ to see the new package it appears that the Homepage url (under Project Links) is broken - just to let you know.

@yikei
Copy link

yikei commented Jan 12, 2022

@thomasfrederikhoeck Appreciate the heads up! We used to have extensive public facing documentation for azureml-dataprep but that has been removed (as we no longer recommend directly using dataprep). We will get that old link removed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants