-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URI pattern being used is being flagged by ttk #10391
Comments
Hi @ashwinvenkatesha, |
Hi @ashwinvenkatesha , can we get to know on which maintemplate you are running the Arm-ttk? If we have "uri" or "url" keyword mentioned in variable name, it will fail with above mentioned error. |
Hi @ashwinvenkatesha , as per the discussion on call, I think you will not be following the approach to call the function app from the workbook, so are we good to close on this? |
Hi @ashwinvenkatesha, Gentle Reminder: We are waiting for your response on this issue. If you still need to keep this issue active, please respond to it in the next 2 days. If we don't receive a response by 15-05-2024 date, we will be closing this issue. |
Hi @ashwinvenkatesha, since we have not received a response from you, we are closing this issue as per our standard operating procedures. If you still need support for this issue, feel free to re-open at any time. Thank you for your co-operation. |
Describe the bug
I am defining a variable called LogAnalyticsURI whose value is a constructed in the below manner.
"variables" : { ... "LogAnaltyicsUri":"[replace(environment().portal, 'https://portal', concat('https://', toLower(parameters('WorkspaceId')), '.ods.opinsights'))]", ... }
When I run arm-ttk locally, this complains that
[-] URIs Should Be Properly Constructed (17 ms) Function 'concat' found within 'LogAnaltyicsUri' Line: 95, Column: 6 Function 'concat' found within 'LogAnaltyicsUri' Line: 101, Column: 6
Tried changing it to,
"LogAnaltyicsUri": "[format('https://%s.ods.opinsights.azure.com', parameters('AzureSentinelWorkspaceId'))]",
This fails as well with the below message
Function 'format' found within 'LogAnaltyicsUri' Line: 95, Column: 6
To Reproduce
Steps to reproduce the behavior:
"variables" : { ... "LogAnaltyicsUri":"[replace(environment().portal, 'https://portal', concat('https://', toLower(parameters('WorkspaceId')), '.ods.opinsights'))]", ... }
Expected behavior
Since most of the contributors are defining this variable in this manner, this definition of LogAnalyticsURi should be allowed.
Screenshots
I am wondering if I submit a pull request, will the same failure occur
The text was updated successfully, but these errors were encountered: