Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate ResetContext in ReplayToken #2307

Closed
CodeDrivenMitch opened this issue Jul 27, 2022 · 0 comments · Fixed by #2312
Closed

Propagate ResetContext in ReplayToken #2307

CodeDrivenMitch opened this issue Jul 27, 2022 · 0 comments · Fixed by #2312
Assignees
@CodeDrivenMitch
Labels
Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: Resolved Use to signal that work on this issue is done. Type: Feature Use to signal an issue is completely new to the project.
Milestone
Release 4.6.0

Comments

@CodeDrivenMitch
Copy link
Member

CodeDrivenMitch commented Jul 27, 2022 •
edited

Feature Description

When resetting a projection the user can supply a ResetContext object of their choosing. This is used to invoke the reset handlers in the processing group.

It would be great if this context can also be carried to event handlers during replay. We can achieve this by saving the ResetContext in the ReplayToken that the user can then extract.

In addition, we should add a ParameterResolverFactory that allows the ResetContext to be passed to the handling method as a parameter.

Possible Workarounds

Users can create their own table and query this at runtime for the information. This requires additional queries for each message handled, while the data is already known at the time the replay is triggered.
@CodeDrivenMitch CodeDrivenMitch added the Type: Feature Use to signal an issue is completely new to the project. label Jul 27, 2022
@CodeDrivenMitch CodeDrivenMitch changed the title ReplayToken is not customizable Make ReplayToken creation customizable Jul 27, 2022
@CodeDrivenMitch CodeDrivenMitch mentioned this issue Jul 27, 2022
Closed
@CodeDrivenMitch CodeDrivenMitch changed the title Make ReplayToken creation customizable Propagate ResetContext in ReplayToken Jul 28, 2022
@smcvb smcvb added Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: Under Discussion Use to signal that the issue in question is being discussed. labels Jul 28, 2022
@smcvb smcvb added this to the Release 4.6.0 milestone Aug 3, 2022
@smcvb smcvb added Status: In Progress Use to signal this issue is actively worked on. and removed Status: Under Discussion Use to signal that the issue in question is being discussed. labels Aug 3, 2022
@smcvb smcvb mentioned this issue Aug 3, 2022
Merged
@close-label close-label bot added the Status: Resolved Use to signal that work on this issue is done. label Aug 3, 2022
CodeDrivenMitch added a commit that referenced this issue Aug 3, 2022
@CodeDrivenMitch
Merge pull request #2312 from AxonFramework/replaytoken-carries-context
1f5cf17 
[#2307] Carry the context during reset to the `ReplayToken`
@CodeDrivenMitch CodeDrivenMitch removed the Status: In Progress Use to signal this issue is actively worked on. label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CodeDrivenMitch CodeDrivenMitch

Labels
Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: Resolved Use to signal that work on this issue is done. Type: Feature Use to signal an issue is completely new to the project.
Projects
None yet
Milestone
Release 4.6.0
2 participants
@CodeDrivenMitch @smcvb