Fix a problem where when a shutdown takes places while the worklaunch… #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gklijs
added
Type: Bug
…er is running, the available threads becomes lower than the initial value.
|
SonarCloud Quality Gate failed. |
smcvb
approved these changes
Jul 28, 2022
There was a problem hiding this comment.
Nice work spotting this, @gklijs. Let's ask @nils-christian if he's able to validate whether this version solves the predicament he's spotted. :-)
gklijs
added
Status: Resolved
|
I'll make sure the new snapshot is available, and post in the related issue for feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a problem where when a shutdown takes places while the worklauncher is running, the available threads becomes lower than the initial value. This in turn may lead to some segments not being processed.
The change makes sure the available thread count is always increased on cleanup.
Fixes #2293