Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added java 17 to the main build #1958

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Added java 17 to the main build #1958

merged 1 commit into from
Sep 29, 2021

Conversation

lfgcampos
Copy link
Contributor

@lfgcampos lfgcampos commented Sep 29, 2021 •
edited

Added java 17 to the build and some extra improvements to the build file.

It might be hard to merge it to master later on since our master build files are different from this branch but we can work out on master when needed.

from logs:

Java configuration:
Distribution: zulu
Version: 17.0.0+35
Path: /opt/hostedtoolcache/Java_Zulu_jdk/17.0.0-35/x64

@lfgcampos lfgcampos added Type: Enhancement Use to signal an issue enhances an already existing feature of the project. Priority 2: Should High priority. Ideally, these issues are part of the release they’re assigned to. Status: In Progress Use to signal this issue is actively worked on. labels Sep 29, 2021
@lfgcampos lfgcampos added this to the Release 4.5.4 milestone Sep 29, 2021
@lfgcampos lfgcampos self-assigned this Sep 29, 2021
@lfgcampos lfgcampos mentioned this pull request Sep 29, 2021
Closed
@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

smcvb
smcvb approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@smcvb
Copy link
Member

smcvb commented Sep 29, 2021

Let's merge this and fix the JDK 17 requirements in another pull request.

@smcvb smcvb merged commit c6b610d into axon-4.5.x Sep 29, 2021
@smcvb smcvb deleted the add-java17-on-build branch September 29, 2021 10:06
@smcvb smcvb added Status: Resolved Use to signal that work on this issue is done. and removed Status: In Progress Use to signal this issue is actively worked on. labels Sep 29, 2021
@lfgcampos lfgcampos mentioned this pull request Oct 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcvb smcvb smcvb approved these changes

Assignees

@lfgcampos lfgcampos

Labels
Priority 2: Should High priority. Ideally, these issues are part of the release they’re assigned to. Status: Resolved Use to signal that work on this issue is done. Type: Enhancement Use to signal an issue enhances an already existing feature of the project.
Projects
None yet
Milestone
Release 4.5.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lfgcampos @smcvb