Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify LockFactory configuration per aggregate #1490

Closed
smcvb opened this issue Aug 13, 2020 · 0 comments · Fixed by #1992
Closed

Simplify LockFactory configuration per aggregate #1490

smcvb opened this issue Aug 13, 2020 · 0 comments · Fixed by #1992
Assignees
@smcvb
Labels
Ideal for Contribution Priority 4: Would Lowest priority. Would-be-nice to include issues when time allows it. Status: Resolved Use to signal that work on this issue is done. Type: Feature Use to signal an issue is completely new to the project.
Milestone
Release 4.6.0

Comments

@smcvb
Copy link
Member

smcvb commented Aug 13, 2020

If a user wants to change the LockFactory configuration, they currently have to provide an instance of the aggregate's Repository and set it correctly. This is less user friendly than for example the configuration of a SnapshotFilter, AggregateFactory, SnapshotTriggerDefintion, CommandTargetResolver, etc. It would thus be beneficial if users can provide the desired LockFactory through the AggregateConfigurer or the @Aggregate annotation by specifying the bean name.
@smcvb smcvb added Priority 4: Would Lowest priority. Would-be-nice to include issues when time allows it. Type: Feature Use to signal an issue is completely new to the project. labels Aug 13, 2020
@smcvb smcvb added this to the Release 4.6.0 milestone Sep 3, 2021
@smcvb smcvb self-assigned this Oct 29, 2021
@smcvb smcvb added the Status: In Progress Use to signal this issue is actively worked on. label Oct 29, 2021
smcvb added a commit that referenced this issue Oct 29, 2021
@smcvb
Allow configuration of the LockFactory
3ca8b90 
Add a configureLockFactory() method and use the subsequently configured
LockFactory for the construction of the repository.

#1490
smcvb added a commit that referenced this issue Oct 29, 2021
@smcvb
Allow configuration of the LockFactory through a bean name
99e77e9 
Add a lockFactory() field to the @aggregate annotation that references a
 LockFactory bean name. Adjust the SpringAxonAutoConfigurer accordingly
 to attach a LockFactory bean with that name with the
 AggregateConfigurer

#1490
@smcvb smcvb mentioned this issue Oct 29, 2021
Merged
@close-label close-label bot added the Status: Resolved Use to signal that work on this issue is done. label Nov 1, 2021
smcvb added a commit that referenced this issue Nov 1, 2021
@smcvb
Merge pull request #1992 from AxonFramework/feature/1490
8f08efe 
[#1490] Simplify LockFactory configuration for Aggregates
@smcvb smcvb removed the Status: In Progress Use to signal this issue is actively worked on. label Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smcvb smcvb

Labels
Ideal for Contribution Priority 4: Would Lowest priority. Would-be-nice to include issues when time allows it. Status: Resolved Use to signal that work on this issue is done. Type: Feature Use to signal an issue is completely new to the project.
Projects
None yet
Milestone
Release 4.6.0
Development

Successfully merging a pull request may close this issue.

[#1490] Simplify LockFactory configuration for Aggregates AxonFramework/AxonFramework
1 participant
@smcvb