Skip to content
This repository has been archived by the owner on Feb 19, 2020. It is now read-only.

Ditch babel5 dependency #200

Closed
blowery opened this issue Jun 6, 2016 · 3 comments
Closed

Ditch babel5 dependency #200

blowery opened this issue Jun 6, 2016 · 3 comments

Comments

@blowery
Copy link
Contributor

blowery commented Jun 6, 2016

Pulling a hard dependency on babel 5 is unnecessary. Consider switching to es6-promise which doesn't have as much baggage for downstream projects.

@TooTallNate
Copy link
Contributor

TooTallNate commented Jun 9, 2016

@blowery babel-runtime is used in other places as well unfortunately, so it's not just Promise.

I'm thinking that upgrading to Babel 6 and a major version bump for wpcom.js might be good enough to satisfy Automattic/wp-calypso#1515. Yay or nay?

@TooTallNate
Copy link
Contributor

Note that I'm also planning on removing babel as a dependency in general. It should be a dev dependency and not installed when being consumed by a parent module.

babel-runtime as a dep I don't really see any way of removing, short of refactoring all the code to not use ES6 anymore, but I don't think that's the direction we want to go in.

@TooTallNate
Copy link
Contributor

Fixed by #201.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants