Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream to prettier/prettier? #13

Closed
coderkevin opened this issue Dec 31, 2018 · 5 comments
Closed

Upstream to prettier/prettier? #13

coderkevin opened this issue Dec 31, 2018 · 5 comments
Labels

Comments

@coderkevin
Copy link

I looked and didn't see a PR on prettier/prettier to upstream the --paren-spacing option. Is this ready to be done yet? If it were upstreamed as an option with a default of 0, then this fork would no longer have to be maintained, if I'm understanding correctly.

@samouri
Copy link

samouri commented Dec 31, 2018

Jarda already attempted this: prettier#2372

@coderkevin
Copy link
Author

Well that's a shame. Such a simple request. I guess prettier-miscellaneous isn't very attractive either because it's very far behind the upstream master branch now.

@coderkevin
Copy link
Author

If such a fork has to be maintained to be compliant with any WP JS code going forward, perhaps it should be under the WordPress github org? I'm a little surprised the Gutenberg builds aren't using this, but maybe that's why?

@samouri
Copy link

samouri commented Dec 31, 2018

Well that's a shame. Such a simple request.

@coderkevin: they have a pretty strong core principle to resist configuration. Even though it stinks for WP, I think it makes sense for the JS community as a whole. On top of that, one could argue that it is Automattic/WordPress that should adapt its style.

@coderkevin
Copy link
Author

It sounds like this is a no-go, so I'm closing it. 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants