Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Site editor row block has excessive layout shifting #58437

Closed
jeyip opened this issue Nov 23, 2021 · 5 comments
Closed

[Bug]: Site editor row block has excessive layout shifting #58437

jeyip opened this issue Nov 23, 2021 · 5 comments
Assignees

Comments

@jeyip
Copy link
Contributor

jeyip commented Nov 23, 2021

Quick summary

There’s significant content shifting when we justify items in the row block (center, right, left, and space between) and select it. I tested the behavior with 1, 2 and 3 block children.

2021-11-18 23 18 00

Steps to reproduce

  1. Enable full site editing by activating the Gutenberg plugin and an FSE enabled theme (Ex. Quadrat)
  2. Navigate to the site editor
  3. Add a row block
  4. Add two items into the row block
  5. Open the row block settings sidebar
  6. Change the content justification to space between
  7. Unselect the row block
  8. Reselect it and verify that the content jumps

What you expected to happen

I would expect no layout shifting when selecting a row block with content

What actually happened

There was layout shifting when selecting a row block with content

Browser

Google Chrome/Chromium

Simple/Atomic

Reproduced on simple sites

Reproducibility

Consistent

@jeyip jeyip changed the title [Bug]: [Bug]: Site editor row block has excessive layout shifting Nov 23, 2021
@jeyip jeyip added [Pri] Normal and removed Needs triage Ticket needs to be triaged labels Nov 23, 2021
@mtias
Copy link
Member

mtias commented Nov 24, 2021

This should be addressed in gutenberg trunk. Can you check?

@jeyip
Copy link
Contributor Author

jeyip commented Nov 24, 2021

@mtias Those we’re my exact thoughts as well, and I did check in my core Gutenberg dev environment before drafting this issue. I was only able to reproduce the problem on dotcom.

Hopefully the fix is already in core Gutenberg, and it’s simply a matter of waiting for a future Gutenberg release on dotcom to resolve everything 🤞

@jeyip jeyip self-assigned this Nov 30, 2021
@jeyip
Copy link
Contributor Author

jeyip commented Nov 30, 2021

I did some css debugging. The reason we only see it on Dotcom is because a fix was merged into core Gutenberg a week ago.

It doesn’t look like the fix made it into Gutenberg v12, but it should be resolved by v13.

@jeyip jeyip added the [Status] Fix Inbound Use when a fix is in unreleased component label Nov 30, 2021
@mtias
Copy link
Member

mtias commented Nov 30, 2021

Yes, it should come with 12.1.

@jeyip
Copy link
Contributor Author

jeyip commented Dec 9, 2021

Solved with the release of 12.1 on simple sites

@jeyip jeyip closed this as completed Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants