Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Supports PHP:" value for all themes #7785

Open
creativecoder opened this issue Apr 29, 2024 · 1 comment
Open

Update "Supports PHP:" value for all themes #7785

creativecoder opened this issue Apr 29, 2024 · 1 comment
Labels
[Pri] TBD [Type] Bug Something isn't working

Comments

@creativecoder
Copy link
Contributor

creativecoder commented Apr 29, 2024

We've been adding declare( strict_types=1 ); to theme PHP files because of WP.com deploy requirements.

This mode was added in PHP 7. Currently most (all?) themes in this repo declare "Support PHP: 5.x" in the style.css header.

We need to update this to correctly require PHP 7.0+, to indicate that themes may trigger errors if used with older PHP versions.

@creativecoder creativecoder added the [Type] Bug Something isn't working label Apr 29, 2024
@mrfoxtalbot mrfoxtalbot added [Type] Enhancement New feature or request and removed [Type] Bug Something isn't working labels Apr 30, 2024
@creativecoder creativecoder added [Type] Bug Something isn't working and removed [Type] Enhancement New feature or request labels May 23, 2024
@creativecoder
Copy link
Contributor Author

I've restored [Type] Bug for this issue--fixing incorrect PHP compatibility information is not an enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] TBD [Type] Bug Something isn't working
Projects
Development

No branches or pull requests

2 participants