Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varia themes: Default text Color inside the Cover Block is not the same in the editor and the front-end #4993

Closed
AtrumGeost opened this issue Nov 4, 2021 · 20 comments
Labels
[Pri] High [Theme] Hever [Theme] Varia Triaged [Type] Bug Something isn't working User Report This issue was created following a WordPress customer report

Comments

@AtrumGeost
Copy link

Steps to replicate

  1. Activate the Hever theme and select the option to replace the Home page
  2. Open the new Home page in the editor
  3. Notice the color of the text inside the Cover block (white)
  4. Notice the color on the actual site (black)

Result

Screen Shot on 2021-11-04 at 11-29-21

Expected

To have the same color as in the editor:

Screen Shot on 2021-11-04 at 11:30:11

  • User report: 4429491-zd-woothemes
@dcoleonline
Copy link

Also in 4424948-zen

We should update them once this is resolved. For now, I've manually set the color option in the editor to override this issue.

@AtrumGeost
Copy link
Author

Another report here:

4452487-zd-woothemes

@jordesign jordesign changed the title Hever: Color inside the Cover Block is not the same in the editor and the front-end Varia themes: De fault textColor inside the Cover Block is not the same in the editor and the front-end Nov 16, 2021
@jordesign
Copy link
Contributor

With some testing I've been able to narrow down this issue a little more. It appears to happen in the Varia parent theme and all child themes. (all I tested anyway).

The issue is that the default text color for content within Cover blocks (and others as well like Form blocks) isn't matching between editor and front-end preview.

Case (you can check Pdw1nU-d-p2 for testing):

Editor (default text appears white):

Screen Shot 2021-11-17 at 6 57 48 am

Front End (default text appears dark):
Screen Shot 2021-11-17 at 6 58 49 am


For bonus weirdness I made some changes to the colors in the customizer - and they had unexpected effects on the color pallet in the editor and the front end.

Customizer change (changing default text color to light green):
This changed text colors even when other colors had already been specifically applied (using color presets in the editor)

Screen Shot 2021-11-17 at 7 00 08 am

In the Editor:

Screen Shot 2021-11-17 at 7 00 55 am


Noting that the match of color labels between Customizer and Editor (and the fact they are in different positions) are:

Background > Background
Text Color > Foreground
Link Color > Primary
Secondary > Secondary

@jordesign
Copy link
Contributor

As this appears to be affecting all Varia themes - I'm raising it as high priority.

@jordesign jordesign added this to HE Triaged in Bug Scrub Planning Nov 16, 2021
@jordesign jordesign changed the title Varia themes: De fault textColor inside the Cover Block is not the same in the editor and the front-end Varia themes: Default textbColor inside the Cover Block is not the same in the editor and the front-end Nov 16, 2021
@jordesign
Copy link
Contributor

Could this be related to the introduction of Opacity for background colors in Gutenberg 11.8?
WordPress/gutenberg#35065

@jordesign jordesign changed the title Varia themes: Default textbColor inside the Cover Block is not the same in the editor and the front-end Varia themes: Default text Color inside the Cover Block is not the same in the editor and the front-end Nov 16, 2021
@mrsjaved
Copy link

mrsjaved commented Nov 17, 2021

Another report here 18999453-hc
Follow-up ticket: 4462522-zd-woothemes user wants to receive an update when the issue is resolved.

@AtrumGeost
Copy link
Author

Another report here: 4463353-zd-woothemes

@mrsjaved
Copy link

Another report here: 4063903-hc

@jartes
Copy link

jartes commented Nov 19, 2021

Another one on 30758439-hc

Did some CSS for them to fix colors manually.

@ccwalburn
Copy link

Another report here: 32814121-hc
Had them manually set the color in the editor

@vinnykaur
Copy link

One more - 4531506-zd
Had to set the color manually from the block settings.

@vinnykaur
Copy link

4462244-zd
Had them set the color manually from the block settings.

@csonnek
Copy link
Member

csonnek commented Nov 22, 2021

@AtrumGeost
Copy link
Author

Another report here 4534534-zd-woothemes

@kriskorn
Copy link

Another report here: 28882174-hc
Had them manually set the color in the editor.

@lunasera41
Copy link

lunasera41 commented Dec 7, 2021

Another report here: 4575897-zd-woothemes
Asked them to manually set the color in the editor
Stow theme

@jackiejade
Copy link

Another report: 30891016-hc

Manually switching the color in the editor fixed the issue.

@jartes
Copy link

jartes commented Dec 13, 2021

Another one on: 33146819-hc

Indicated to set the color manually.

@ai2n
Copy link

ai2n commented Dec 15, 2021

I think another related one in: 4613234-zen

It seems they somehow were able to solve it in between the time I pushed to ticket and followed up with them, but I suggested a manual workaround just in case.

@scruffian
Copy link
Member

This should have been fixed by #5212

Bug Scrub Planning automation moved this from Needs Deploy to Done Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] High [Theme] Hever [Theme] Varia Triaged [Type] Bug Something isn't working User Report This issue was created following a WordPress customer report
Projects
Development

No branches or pull requests