Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme.md SERVER_PORT to client url #1359

Merged
merged 2 commits into from Sep 29, 2020

Conversation

mipra282
Copy link
Contributor

@mipra282 mipra282 commented Apr 24, 2020

Note: the socket.io.js file is the generated output of make socket.io.js, and should not be manually modified.

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

New behaviour

Other information (e.g. related issues)

@mipra282
Copy link
Contributor Author

Note: the socket.io.js file is the generated output of make socket.io.js, and should not be manually modified.

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

New behaviour

Other information (e.g. related issues)

@darrachequesne darrachequesne merged commit 6ce02ee into socketio:master Sep 29, 2020
@darrachequesne
Copy link
Member

Thanks!

@darrachequesne darrachequesne added this to the 2.3.1 milestone Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants