Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added section about Debug / logging on the client side #1278

Merged
merged 2 commits into from Sep 30, 2020

Conversation

devmi
Copy link
Contributor

@devmi devmi commented Feb 27, 2019

Note: the socket.io.js file is the generated output of make socket.io.js, and should not be manually modified.

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

No info about Debug / logging

New behaviour

added section about Debug / logging on the client side

@devmi
Copy link
Contributor Author

devmi commented Apr 2, 2019

Is this a (partially) abandoned project? Changing a few lines on a README.md file should not cause fails on CI build. Most likely the build script itself needs to be fixed.

@darrachequesne darrachequesne merged commit 0c39f14 into socketio:master Sep 30, 2020
@darrachequesne
Copy link
Member

@devmi yes, the tests were failing due to an unrelated issue. Thanks for this 👍

@darrachequesne darrachequesne added this to the 2.3.1 milestone Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants