Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedded APK? #1589

Open
IzzySoft opened this issue Mar 15, 2023 · 2 comments
Open

embedded APK? #1589

IzzySoft opened this issue Mar 15, 2023 · 2 comments

Comments

@IzzySoft
Copy link

My scanner just alerted me about an embedded APK. Can you please clarify what res/raw/android_wear_micro_apk.apk is for? I guess that's pushed to the Wear device by your app? Trouble is, that embedded APK contains non-free dependencies (well, it's Wear):

Offending libs:
---------------
* Android Wear APIs (/com/google/android/gms/wearable): NonFreeDep
* Google Mobile Services (/com/google/android/gms): NonFreeDep

2 offenders.

Which makes the entire app non-free. Is this embedded APK essential for SimpleNote itself? If not (which I assume), would it be possible to have a "foss build flavor" coming without it?

@peril-automattic
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

🚫 Please add a feature label to this issue. e.g. 'Stats'

Generated by 🚫 dangerJS

@IzzySoft
Copy link
Author

Uck, sorry – I see the app already carries the anti-features NonFreeDep, NonFreeNet and Tracking. So please let me amend: if that alternative flavor had Automattic-Tracks-Android removed and Sentry strictly opt-in, the Tracking anti-feature could be dropped. NonFreeNet is caused by BillingClient, and NonFreeDep by BillingClient, Wear & GMS. So I might ask a little too much here – still, I try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant