Update has_lib.js to support Apple M1 with homebrew #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support from Mac M1 homebrew install of `pkg-config cairo pango libpng jpeg giflib librsvg`, which installs libraries under `/opt/homebrew/` instead `/usr/local/`
|
Awesome 👍 |
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stated instructions for compiling on OS X include using homebrew:
brew install pkg-config cairo pango libpng jpeg giflib librsvgHowever on Apple M1 silicon, the compile via binding.gyp will fail to locate the above library packages. This is because on M1, homebrew places all installed libraries at
/opt/homebrew/lib, unlike on Intel silicon, where it would place them under/usr/local/lib.The simple remedy is to add
/opt/homebrew/libto the SYSTEM_PATHS ofhas_lib.jsFixes: #1782