Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly check return value from Set and Call #1415

Merged
merged 1 commit into from Jun 10, 2019
Merged

Properly check return value from Set and Call #1415

merged 1 commit into from Jun 10, 2019

Conversation

LinusU
Copy link
Collaborator

@LinusU LinusU commented May 1, 2019

Thanks for contributing!

  • Have you updated CHANGELOG.md?

@LinusU LinusU mentioned this pull request May 1, 2019
Closed
@LinusU
Copy link
Collaborator Author

LinusU commented May 1, 2019

Blocked on nodejs/nan#851

LinusU
LinusU commented May 16, 2019
View reviewed changes
src/Backends.cc Outdated Show resolved Hide resolved
@zbjornson
Copy link
Collaborator

I think this can land now with Nan 2.14.0. :shipit:

@LinusU
Copy link
Collaborator Author

LinusU commented Jun 10, 2019

Rebased on master and upgraded nan 🚀

@LinusU LinusU merged commit 8dcd0da into master Jun 10, 2019
@LinusU LinusU deleted the nan-fixes branch June 10, 2019 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LinusU @zbjornson