Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use simple-get for fetching images #1398

Merged
merged 1 commit into from Apr 2, 2019
Merged

Use simple-get for fetching images #1398

merged 1 commit into from Apr 2, 2019

Conversation

LinusU
Copy link
Collaborator

@LinusU LinusU commented Apr 1, 2019 •
edited

Thanks for contributing!

  • Have you updated CHANGELOG.md?

This should fix #1389 and replace #1390

@LinusU
Copy link
Collaborator Author

LinusU commented Apr 1, 2019

I used simple-get because it was the absolute smallest library out of those I looked at, and I've used it before with great success.

Screenshot 2019-04-01 at 18 27 59

(ref: https://www.npmtrends.com/got-vs-needle-vs-request-vs-simple-get-vs-superagent-vs-axios-vs-node-fetch)

Also have a branch up using got here: master...LinusU:got

@LinusU LinusU requested a review from zbjornson April 1, 2019 17:29
zbjornson
zbjornson approved these changes Apr 1, 2019
View reviewed changes
Copy link
Collaborator

@zbjornson zbjornson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart change!

@LinusU LinusU merged commit 2689a1e into Automattic:master Apr 2, 2019
@LinusU LinusU deleted the simple-get branch April 2, 2019 10:08
@LinusU LinusU mentioned this pull request Apr 2, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbjornson zbjornson zbjornson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues for URLs with 302 redirect
2 participants
@LinusU @zbjornson