replace var with const #9394
Merged
replace var with const #9394
+86
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
requested changes
Sep 7, 2020
There was a problem hiding this comment.
Looks great, other than the arrow function changes, which have numerous issues. Can you please undo those?
docs/guide.pug
Outdated
| animalSchema.methods.findSimilarTypes = function(cb) { | ||
| return mongoose.model('Animal').find({ type: this.type }, cb); | ||
| }; | ||
| animalSchema.methods.findSimilarTypes = cb => ( |
There was a problem hiding this comment.
This change doesn't work because the method uses this, which arrow functions mess up.
docs/guide.pug
Outdated
| animalSchema.statics.findByName = function(name) { | ||
| return this.find({ name: new RegExp(name, 'i') }); | ||
| }; | ||
| animalSchema.statics.findByName = name => ( |
There was a problem hiding this comment.
This change doesn't work because the static function uses this, which arrow functions mess up.
docs/guide.pug
Outdated
| animalSchema.static('findByBreed', function(breed) { | ||
| return this.find({ breed }); | ||
| }); | ||
| animalSchema.static('findByBreed', breed => this.find({ breed }) ) |
There was a problem hiding this comment.
This change doesn't work because the static function uses this, which arrow functions mess up.
docs/guide.pug
Outdated
| @@ -325,7 +323,7 @@ block content | |||
| define a `fullName` property that won't get persisted to MongoDB. | |||
|
|
|||
| ```javascript | |||
| personSchema.virtual('fullName').get(function () { | |||
| personSchema.virtual('fullName').get(() => { | |||
There was a problem hiding this comment.
This change doesn't work because the virtual getter uses this, which arrow functions mess up.
|
Oh! Sorry. That's a major issue. Will remove those. Thanks |
vkarpov15
approved these changes
Sep 10, 2020
vkarpov15
added
the
docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory.
If you're making a change to documentation, do not modify a
.htmlfile directly. Instead find the corresponding.pugfile or test case in thetest/docsdirectory.Summary
Examples