Skip to content

fix(array): only cast array to proper depth if it contains an non-array value #9217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2020

Conversation

cyrilgandon
Copy link
Contributor

Fixes #9215

@cyrilgandon cyrilgandon force-pushed the cgandon/fix/array-casting branch from a98b9c6 to db3a5bb Compare July 8, 2020 14:56
@cyrilgandon cyrilgandon force-pushed the cgandon/fix/array-casting branch from db3a5bb to 5f1cbf0 Compare July 8, 2020 14:57
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent work, thanks so much @cyrilgandon 👍

@vkarpov15 vkarpov15 added this to the 5.9.23 milestone Jul 8, 2020
@vkarpov15 vkarpov15 merged commit bd51a82 into Automattic:master Jul 8, 2020
@cyrilgandon cyrilgandon deleted the cgandon/fix/array-casting branch July 8, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [[[Number]]] does not want to save my [[]] array correctly
2 participants