Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make calling mongoose.connect() while connecting or connected a no-op #9203

Closed
vkarpov15 opened this issue Jul 4, 2020 · 2 comments
Closed

Make calling mongoose.connect() while connecting or connected a no-op #9203

vkarpov15 opened this issue Jul 4, 2020 · 2 comments
Milestone
5.10

Comments

@vkarpov15
Copy link
Collaborator

Calling mongoose.connect() multiple times currently causes issues (#9167, #9107) , but unfortunately people do that quite frequently. Should be fine to introduce this in a minor release.
@vkarpov15 vkarpov15 added this to the 5.10 milestone Jul 4, 2020
@vkarpov15
Copy link
Collaborator Author

Also need to make sure the connection string is the same. Calling mongoose.connect() with a different connection string or db name while already connecting or connected should throw an error.

vkarpov15 added a commit that referenced this issue Jul 5, 2020
@vkarpov15
fix(connection): throw error when calling openUri() on a connected …
ae9c686 
…or connecting connection with a different URI

Fix #9203
@roychri
Copy link

roychri commented Aug 17, 2020

I think this change causes problems now.

#9335

@jamesfarrell97 jamesfarrell97 mentioned this issue Aug 27, 2020
Closed
@josephstgh josephstgh mentioned this issue Sep 22, 2020
Closed
@vkarpov15 vkarpov15 mentioned this issue Jun 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.10
Development

No branches or pull requests
3 participants
@vkarpov15 @roychri @AbdelrahmanHafez