Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(document): add Document#getChanges #9097

Merged
merged 4 commits into from Jun 15, 2020

Conversation

AbdelrahmanHafez
Copy link
Collaborator

fixes #9096

@AbdelrahmanHafez AbdelrahmanHafez added this to the 5.10 milestone Jun 5, 2020
@AbdelrahmanHafez
Copy link
Collaborator Author

Interesting that it would mark the build as failed even though all the checks in travis have succeeded
🤨

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍 the only suggestion I might have is naming.

What do you think of just Document#changes(), or Document#delta()?

@AbdelrahmanHafez
Copy link
Collaborator Author

I find naming functions/methods as verbs more descriptive, according to Bob Martin's Clean Code, so I'd prefer getChanges or getDelta over just changes or delta.

What do you think?

@vkarpov15 vkarpov15 changed the base branch from master to 5.10 June 15, 2020 18:26
@vkarpov15
Copy link
Collaborator

Works for me, I think that's more consistent with the existing document API anyway. Document methods are verbs currently.

@vkarpov15 vkarpov15 merged commit 7cc8823 into Automattic:5.10 Jun 15, 2020
vkarpov15 added a commit that referenced this pull request Jun 15, 2020
@AbdelrahmanHafez AbdelrahmanHafez deleted the gh-9096 branch June 15, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document#getChanges()
2 participants