Fix SchemaType.clone() #8542
Merged
Fix SchemaType.clone() #8542
+101
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
SchemaType.clone()was not copying values where updates had been made after instantiation.I figured that testing using
assert.deepStrictEqualmade the most sense here, but perhaps it's overkill and the if (x !== undefined) are unecessary? I'll happily adjust if you have a preference.Also, I thought the rename schema.type.test.js → test/schematype.test.js made sense as it seems to be testing shared functionality, again will adjust if you prefer the old style.