Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(api) fix Connection.close return param #8258

Merged
merged 1 commit into from Oct 18, 2019
Merged

docs(api) fix Connection.close return param #8258

merged 1 commit into from Oct 18, 2019

Conversation

gosuhiman
Copy link
Contributor

Summary

I've fixed jsdoc for Connection.close public method. It's in fact returning a promise, not a Connection object.

@gosuhiman gosuhiman changed the title Update Connection.close docs [docs] fix Connection.close return param Oct 18, 2019
@gosuhiman gosuhiman changed the title [docs] fix Connection.close return param docs(api) fix Connection.close return param Oct 18, 2019
vkarpov15
vkarpov15 approved these changes Oct 18, 2019
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@vkarpov15 vkarpov15 added this to the 5.7.6 milestone Oct 18, 2019
@vkarpov15 vkarpov15 added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label Oct 18, 2019
@vkarpov15 vkarpov15 merged commit c337999 into Automattic:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Milestone
5.7.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gosuhiman @vkarpov15