Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previously fixed bug was reintroduced #8173

Closed
jimmytsao opened this issue Sep 17, 2019 · 1 comment
Closed

Previously fixed bug was reintroduced #8173

jimmytsao opened this issue Sep 17, 2019 · 1 comment
Labels
confirmed-bug We've confirmed this is a bug in Mongoose and will fix it.
Milestone
5.7.3

Comments

@jimmytsao
Copy link

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
A previously reported bug was fixed in version 5.1.3 of mongoose. Starting with version 5.2.5, the bug has been reintroduced.

Previously fixed bug: #6488

If the current behavior is a bug, please provide the steps to reproduce.

See the reproduction script in the link above under the section:

Virtual Population NOT WORKING When Virtual Field Is Nested Within Embedded Object Schema

What is the expected behavior?
I expected the issue to be resolved in all versions after 5.1.3

What are the versions of Node.js, Mongoose and MongoDB you are using? Note that "latest" is not a version.
mongoose: 5.7.1
node: 10.14.1
mongo: 3.6.4
@vkarpov15 vkarpov15 added this to the 5.7.3 milestone Sep 23, 2019
@vkarpov15 vkarpov15 added the has repro script There is a repro script, the Mongoose devs need to confirm that it reproduces the issue label Sep 23, 2019
vkarpov15 added a commit that referenced this issue Sep 24, 2019
@vkarpov15
test(populate): repro #8173 #6488
b42d0f5
@vkarpov15
Copy link
Collaborator

Sorry for the trouble, it looks like our test case for #6488 didn't test the full integration, just tested a unit that happened to cause this issue in 2018. We added a full integration test for this issue, so virtual populate on a nested schema within an embedded discriminator should work fine going forward as of 5.7.3 👍

@vkarpov15 vkarpov15 added confirmed-bug We've confirmed this is a bug in Mongoose and will fix it. and removed has repro script There is a repro script, the Mongoose devs need to confirm that it reproduces the issue labels Sep 24, 2019
This was referenced Mar 11, 2021
Merged
Open
Open
Closed
Merged
Open
Merged
Closed
Merged
Merged
Closed
Open
Open
This was referenced Mar 18, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug We've confirmed this is a bug in Mongoose and will fix it.
Projects
None yet
Milestone
5.7.3
Development

No branches or pull requests
2 participants
@vkarpov15 @jimmytsao