Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parallel): fix parallelLimit when fns is empty #8130

Merged
merged 1 commit into from
Sep 4, 2019
Merged

fix(parallel): fix parallelLimit when fns is empty #8130

merged 1 commit into from
Sep 4, 2019

Conversation

sibelius
Copy link
Contributor

@sibelius sibelius commented Sep 4, 2019

fix #8128

Summary

new parallelLimit has a bug in an edge case

Examples

check #8128

vkarpov15
vkarpov15 approved these changes Sep 4, 2019
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this 👍

@vkarpov15 vkarpov15 added this to the 5.6.13 milestone Sep 4, 2019
@vkarpov15 vkarpov15 merged commit cad316a into Automattic:master Sep 4, 2019
@sibelius
Copy link
Contributor Author

sibelius commented Sep 4, 2019

Where can we add a regression test?

vkarpov15 added a commit that referenced this pull request Sep 4, 2019
@vkarpov15
test(model): add test for #8130
3a105e6
@vkarpov15
Copy link
Collaborator

@sibelius I added one ☝️

@vkarpov15 vkarpov15 mentioned this pull request Sep 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.6.13
Development

Successfully merging this pull request may close these issues.

Cannot read property 'filter' of undefined
2 participants
@sibelius @vkarpov15