Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove async dependency #8073

Closed
vkarpov15 opened this issue Aug 16, 2019 · 0 comments
Closed

Remove async dependency #8073

vkarpov15 opened this issue Aug 16, 2019 · 0 comments
Labels
refactor This is a purely internal change for making Mongoose internals easier to understand and work with
Milestone
5.7.3

Comments

@vkarpov15
Copy link
Collaborator

No reason for async to be a prod dependency, we don't use async very often and it causes false security warnings like #8068
@vkarpov15 vkarpov15 added the refactor This is a purely internal change for making Mongoose internals easier to understand and work with label Aug 16, 2019
@vkarpov15 vkarpov15 added this to the 5.6.10 milestone Aug 16, 2019
vkarpov15 added a commit that referenced this issue Aug 16, 2019
@vkarpov15
refactor(document): remove async.each() dependencies
e98d2f7 
Re: #8073
vkarpov15 added a commit that referenced this issue Aug 18, 2019
@vkarpov15
refactor: remove async.parallel() calls
20fa775 
Re: #8073
vkarpov15 added a commit that referenced this issue Aug 18, 2019
@vkarpov15
test: fix tests re: #8073
5c2fbc5
@vkarpov15 vkarpov15 modified the milestones: 5.6.10, 5.6.11, 5.6.12 Aug 21, 2019
vkarpov15 added a commit that referenced this issue Sep 2, 2019
@vkarpov15
refactor(model): use internal parallelLimit() instead of async
03dfc6a 
Re: #8073
@vkarpov15 vkarpov15 modified the milestones: 5.6.12, 5.6.13, 5.7.1 Sep 3, 2019
@vkarpov15 vkarpov15 modified the milestones: 5.7.1, 5.7.3 Sep 11, 2019
@vkarpov15 vkarpov15 modified the milestones: 5.7.3, 5.7.4 Sep 27, 2019
vkarpov15 pushed a commit that referenced this issue Sep 27, 2019
refactor(cursor): remove dependency on async.times()
e60db1b 
Re: #8073
Re: #5502
@vkarpov15 vkarpov15 modified the milestones: 5.7.3, 5.7.4 Sep 27, 2019
vkarpov15 added a commit that referenced this issue Sep 28, 2019
@vkarpov15
refactor(cursor): remove async.queue() from eachAsync() re: #8073 #5502
3647292
This was referenced Mar 11, 2021
Merged
Open
Open
This was referenced Mar 12, 2021
Closed
Merged
Open
Merged
Closed
Merged
Merged
Closed
Open
Open
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor This is a purely internal change for making Mongoose internals easier to understand and work with
Projects
None yet
Milestone
5.7.3
Development

No branches or pull requests
1 participant
@vkarpov15