bad problem with ObjectId.isValid()

[ORESoftware]

I am having a helluva a time trying to determining if a value is a valid ObjectId, there seems to be a big problem with this -

I tried

var ObjectId = mongoose.Types.ObjectId;
var ObjectId = mongoose.Schema.Types.ObjectId;

using ObjectId.isValid() and new ObjectId(val);

take a look here:

you can see that the value "95" or 95 slips through:

filter

map

what the heck is going on?
please help, thanks!

[ORESoftware]

oh shit, wtf

/**
* Checks if a value is a valid bson ObjectId
*
* @method
* @return {boolean} return true if the value is a valid bson ObjectId, return false otherwise.
*/
ObjectID.isValid = function isValid(id) {
  if(id == null) return false;

  if(typeof id == 'number')
    return true;
  if(typeof id == 'string') {
    return id.length == 12 || (id.length == 24 && checkForHexRegExp.test(id));
  }
  return false;
};

what is it ok if it's a number? This makes no sense because 5 moments later Mongo will barf saying 95 can't be cast to ObjectId by the database.

[TrejGun]

js-bson looks outdated :(

it also throws error
Buffer.set is deprecated. Use array indexes instead.

can someone update it?

[TrejGun]

oh thats nice mongodb/js-bson#160

[vkarpov15]

new ObjectId(95); is completely valid because a valid ObjectId is any 12 bytes, so the number 95 works just fine. If you want to check for the usual hex string, just use /[a-fA-F0-9]{24}/.test(val);

[fires3as0n]

It works with strings, but if I try to check if id is valid by using ObjectId.isValid(6), passing 6 as a number, and it says that it is fine.
Then I pass it to .findById(6) and get an exception.
UnhandledPromiseRejectionWarning: CastError: Cast to ObjectId failed for value "6" at path "_id" for model "SomeModel" at new CastError (node_modules\mongoose\lib\cast.js:315:32)

So seems like ObjectId.isValid() is really quite a useless stuff unless you implicitly cast data passed to it to a string.