BREAKING CHANGE: copy schema options when merging schemas using `new Schema()` or `Schema.prototype.add()` #13092

vkarpov15 · 2023-02-27T17:24:47Z

Summary

A neat change/feature that was recently requested: if using schema1.add(schema2) and schema1 doesn't have a toJSON or toObject option set, use schema2's toJSON and toObject options.

Examples

…Schema()` or `Schema.prototype.add()`

IslandRhythms

LGTM

adamreisnz · 2023-02-27T20:29:38Z

Yep I like this, thanks @vkarpov15 !

BREAKING CHANGE: copy schema options when merging schemas using `new …

82fd5e4

…Schema()` or `Schema.prototype.add()`

IslandRhythms approved these changes Feb 27, 2023

View reviewed changes

vkarpov15 added this to the 7.0.0-rc1 milestone Feb 27, 2023

vkarpov15 merged commit 73cea77 into master Feb 27, 2023

vkarpov15 deleted the vkarpov15/merge-schema-options branch February 27, 2023 18:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BREAKING CHANGE: copy schema options when merging schemas using `new Schema()` or `Schema.prototype.add()` #13092

BREAKING CHANGE: copy schema options when merging schemas using `new Schema()` or `Schema.prototype.add()` #13092

vkarpov15 commented Feb 27, 2023

IslandRhythms left a comment

adamreisnz commented Feb 27, 2023

BREAKING CHANGE: copy schema options when merging schemas using new Schema() or Schema.prototype.add() #13092

BREAKING CHANGE: copy schema options when merging schemas using new Schema() or Schema.prototype.add() #13092

Conversation

vkarpov15 commented Feb 27, 2023

IslandRhythms left a comment

Choose a reason for hiding this comment

adamreisnz commented Feb 27, 2023

BREAKING CHANGE: copy schema options when merging schemas using `new Schema()` or `Schema.prototype.add()` #13092

BREAKING CHANGE: copy schema options when merging schemas using `new Schema()` or `Schema.prototype.add()` #13092