Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(discriminator.querying): allows update doc with discriminatorKey #13056

Merged
merged 1 commit into from Feb 21, 2023

Conversation

abarriel
Copy link
Contributor

@abarriel abarriel force-pushed the iso-discriminator branch 2 times, most recently from 2ca9a19 to 560e6e8 Compare February 20, 2023 14:19
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Just please undo the formatting changes.

test/model.discriminator.querying.test.js Outdated Show resolved Hide resolved
… error when discriminatorkey is set in payload but with same value
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 6.9.3 milestone Feb 21, 2023
@vkarpov15 vkarpov15 merged commit c7b2b16 into Automattic:master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants