Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid sending empty projection option with queries #13050

Closed
2 tasks done
vkarpov15 opened this issue Feb 18, 2023 · 0 comments · Fixed by #13059
Closed
2 tasks done

Avoid sending empty projection option with queries #13050

vkarpov15 opened this issue Feb 18, 2023 · 0 comments · Fixed by #13059
Milestone

Comments

@vkarpov15
Copy link
Collaborator

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the bug has not already been reported

Mongoose version

6.9.1

Node.js version

16.x

MongoDB server version

Any

Typescript version (if applicable)

No response

Description

The following script shows that Mongoose sends projection: {} to the MongoDB driver, which is unnecessary. Would be ideal if Mongoose didn't set a projection option if the projection is empty.

'use strict';

const mongoose = require('mongoose');
mongoose.set('debug', true);

run().catch(err => console.log(err));

async function run() {
  await mongoose.connect('mongodb://localhost:27017/test');
  const schema = new mongoose.Schema({ name: String });
  const Test = mongoose.model('Test', schema);

  // Prints "Mongoose: tests.findOne({}, { projection: {} })"
  await Test.findOne(); // Sends `projection: {}` to MongoDB
}

Steps to Reproduce

See above

Expected Behavior

No response

@vkarpov15 vkarpov15 added this to the 6.9.3 milestone Feb 18, 2023
vkarpov15 added a commit that referenced this issue Feb 21, 2023
fix(query): avoid sending unnecessary empty projection to MongoDB server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant