Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schematype(UUID): added null check to prevent error on binaryToString conversion #13034

Merged
merged 2 commits into from Feb 15, 2023
Merged

schematype(UUID): added null check to prevent error on binaryToString conversion #13034

merged 2 commits into from Feb 15, 2023

Conversation

lpizzinidev
Copy link
Contributor

closes #13032

@Freezystem
Copy link
Contributor

Freezystem commented Feb 15, 2023 •
edited

Seems a duplicate from #13029
Your test may be better than mine though. Would you like me to add it in my PR ?

vkarpov15
vkarpov15 approved these changes Feb 15, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge both this and #13029 so you both get a contrib. Sorry for delay in code review, we've been working on Mongoose 7. I think this PR has better tests, and prefer the != null check, but #13029 adds a couple of extra checks that are helpful.

@vkarpov15 vkarpov15 added this to the 6.9.2 milestone Feb 15, 2023
@vkarpov15 vkarpov15 merged commit 830af77 into Automattic:master Feb 15, 2023
@Freezystem
Copy link
Contributor

thanks a lot 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.9.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lpizzinidev @Freezystem @vkarpov15