Island rhythms/sync schema options for discriminators #12928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
requested changes
Jan 20, 2023
lib/helpers/model/discriminator.js
Outdated
| const toJSON = schema.options.toJSON; | ||
| const toObject = schema.options.toObject; | ||
| const _id = schema.options._id; | ||
| const id = schema.options.id; | ||
|
|
||
| const keys = Object.keys(schema.options); | ||
| schema.options.discriminatorKey = baseSchema.options.discriminatorKey; | ||
|
|
||
| const hasUserProvidedTypeKey = schema._userProvidedOptions.typeKey != null && baseSchema._userProvidedOptions.typeKey != null; |
There was a problem hiding this comment.
This is a step in the right direction, but I'd like for you to generalize this check for typeKey to all schema options. So if user didn't specify other options in discriminator schema (capped, etc.) then use the base schema's options by default.
There was a problem hiding this comment.
Making the changes you requested causes the test mentioned earlier in the thread to fail.
… schema options Fix #12135
vkarpov15
approved these changes
Feb 4, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So moving this line above the for loop causes this test to fail. It also doesn't solve the issue. The if statement that was added cannot be appended to the check in the for loop for deep equality or it would also cause that same test to fail.