chore(promises): removed support for custom promise libraries #12878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
reviewed
Jan 6, 2023
There was a problem hiding this comment.
In test/connection.test.js we use the package q and bluebird. I wonder if we can remove those tests too? @vkarpov15
lib/helpers/promiseOrCallback.js
Outdated
| @@ -35,7 +34,7 @@ module.exports = function promiseOrCallback(callback, fn, ee, Promise) { | |||
| } | |||
| } | |||
|
|
|||
| Promise = Promise || PromiseProvider.get(); | |||
| Promise = Promise || global.Promise || require('bluebird'); | |||
There was a problem hiding this comment.
What happens if bluebird is not installed? Crash gracefully?
hasezoey
requested changes
Jan 7, 2023
hasezoey
reviewed
Jan 8, 2023
vkarpov15
requested changes
Jan 17, 2023
hasezoey
reviewed
Jan 19, 2023
vkarpov15
approved these changes
Feb 4, 2023
|
Maybe add it as an inclusion to the migration DOC 😅 although it is in the changelog. I went from v5 -> v7 and found out the hard way lol I found this because of that commit message on the main page |
|
just as a note, if you still want to use custom promises, you should be able to do: global.Promise = YourCustomPromise; |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12872