Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for custom promise libraries #12872

Closed
2 tasks done
vkarpov15 opened this issue Jan 4, 2023 · 3 comments · Fixed by #12878
Closed
2 tasks done

Remove support for custom promise libraries #12872

vkarpov15 opened this issue Jan 4, 2023 · 3 comments · Fixed by #12878
Labels
backwards-breaking enhancement This issue is a user-facing general improvement that doesn't fix a bug or add a new feature
Milestone
7.0

Comments

@vkarpov15
Copy link
Collaborator

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

MongoDB Node driver is dropping support for promiseLibrary option, so we should remove support for mongoose.Promise. Worth dropping on our end. You can always switch to bluebird by doing something like global.Promise = require('bluebird')
@vkarpov15 vkarpov15 added the enhancement This issue is a user-facing general improvement that doesn't fix a bug or add a new feature label Jan 4, 2023
@vkarpov15 vkarpov15 added this to the 7.0 milestone Jan 4, 2023
@Uzlopak
Copy link
Collaborator

Uzlopak commented Jan 4, 2023

I agree.

@lpizzinidev lpizzinidev mentioned this issue Jan 6, 2023
Merged
@hasezoey
Copy link
Collaborator

hasezoey commented Jan 7, 2023 •
edited

MongoDB Node driver is dropping support for promiseLibrary option

in which version are they planning to remove that option, in 5.x or some 4.x version?

@vkarpov15
Copy link
Collaborator Author

5.x. Dropping support for an option would be backwards breaking.

vkarpov15 added a commit to lpizzinidev/mongoose that referenced this issue Feb 4, 2023
@vkarpov15
Merge branch '7.0' into Automatticgh-12872
26d9268
vkarpov15 added a commit that referenced this issue Feb 4, 2023
@vkarpov15
Merge pull request #12878 from lpizzinidev/gh-12872
794ee88 
chore(promises): removed support for custom promise libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backwards-breaking enhancement This issue is a user-facing general improvement that doesn't fix a bug or add a new feature
Projects
None yet
Milestone
7.0
Development

Successfully merging a pull request may close this issue.

chore(promises): removed support for custom promise libraries lpizzinidev/mongoose
3 participants
@vkarpov15 @Uzlopak @hasezoey