Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(navbar-search): add missing variable #12841

Merged
merged 1 commit into from Dec 28, 2022

Conversation

hasezoey
Copy link
Collaborator

@hasezoey hasezoey commented Dec 28, 2022

Summary

This PR is for fixing what c3384bc introduced (a missing variable), which makes the search via the navbar impossible (because the script never actually runs)

re #12830

fixes the following current error:

Uncaught ReferenceError: defaultVersion is not defined
    <anonymous> https://mongoosejs.com/docs/js/navbar-search.js:3
    <anonymous> https://mongoosejs.com/docs/js/navbar-search.js:18
[navbar-search.js:3:17](https://mongoosejs.com/docs/js/navbar-search.js)
    <anonymous> https://mongoosejs.com/docs/js/navbar-search.js:3
    <anonymous> https://mongoosejs.com/docs/js/navbar-search.js:18

@hasezoey hasezoey added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label Dec 28, 2022
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, sorry I missed this

@vkarpov15 vkarpov15 added this to the 6.8.2 milestone Dec 28, 2022
@vkarpov15 vkarpov15 merged commit 2aa009b into Automattic:master Dec 28, 2022
@hasezoey hasezoey deleted the addNavBarDefaultVersion branch December 29, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants