chore: fix typescript benchmarks by removing ts-benchmark #12838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12770
Summary
I haven't been able to figure out why the ts-benchmark module is failing. The fact that they ship minified JS to npm makes it tricky to step through the code, but I figured it isn't especially difficult to write a quick script that parses
tsc --extendedDiagnostics
output. One less dependency to worry about too.Examples