Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search content by version #12830

Merged
merged 3 commits into from Dec 27, 2022
Merged

Search content by version #12830

merged 3 commits into from Dec 27, 2022

Conversation

vkarpov15
Copy link
Collaborator

Summary

Will need to backport this change for 5.x for it to take effect. But the idea is that the search page currently hits this project to search a Content collection, which is generated by docs/search.js. With this change, Content will have a version parameter, and we'll filter search results based on version.

Examples

@vkarpov15 vkarpov15 self-assigned this Dec 23, 2022
hasezoey
hasezoey approved these changes Dec 23, 2022
View reviewed changes
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

though preferably the fallback version should not be hardcoded (would add more places that would need it replaced on a version change)

@hasezoey hasezoey added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label Dec 23, 2022
@vkarpov15 vkarpov15 merged commit e3472fa into master Dec 27, 2022
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-12548 branch December 27, 2022 20:10
vkarpov15 added a commit that referenced this pull request Dec 27, 2022
@vkarpov15
docs: backport #12830 to 5.x
fd1fa9d
vkarpov15 added a commit that referenced this pull request Dec 27, 2022
@vkarpov15
chore: update 5.x docs for search improvements re: #12830
c505a41
vkarpov15 added a commit that referenced this pull request Dec 27, 2022
@vkarpov15
docs: fix search re: #12830
c3384bc
vkarpov15 added a commit that referenced this pull request Dec 28, 2022
@vkarpov15
docs: quick fix for search re: #12830
aef4c7b
hasezoey added a commit to hasezoey/mongoose that referenced this pull request Dec 28, 2022
@hasezoey
docs(navbar-search): add missing variables
a46ee18 
was broken by c3384bc

re Automattic#12830
@hasezoey hasezoey mentioned this pull request Dec 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees

@vkarpov15 vkarpov15

Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vkarpov15 @hasezoey