fix(schema): propagate strictQuery to implicitly created schemas for embedded discriminators #12827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12796
Summary
The root cause of #12796 is that we don't propagate
strictQuery
to implicitly created schemas like we dostrict
. So if globalstrictQuery
is false, but the implicitly created schema'sstrictQuery
is true. That gets even more confusing because embedded discriminator schemas do pick up the globalstrictQuery
default, so with globalstrictQuery = false
you get an error every time you create an embedded discriminator.Examples