Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): fix unexpected validation error when doing findOneAndReplace() with a nullish value #12826

Merged
merged 1 commit into from Dec 23, 2022
Merged

fix(query): fix unexpected validation error when doing findOneAndReplace() with a nullish value #12826

merged 1 commit into from Dec 23, 2022

Conversation

vkarpov15
Copy link
Collaborator

@vkarpov15 vkarpov15 commented Dec 22, 2022 •
edited

Fix #12821

Summary

#12797 missed a small edge case where val can be nullish.

Examples

AbdelrahmanHafez
AbdelrahmanHafez approved these changes Dec 23, 2022
View reviewed changes
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

hasezoey
hasezoey approved these changes Dec 23, 2022
View reviewed changes
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkarpov15 vkarpov15 merged commit fb145bf into master Dec 23, 2022
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-12821 branch December 23, 2022 15:55
@lpizzinidev lpizzinidev mentioned this pull request Feb 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez approved these changes

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validation failed, when updating document after update mongoose version 6.8.0 to 6.8.1
3 participants
@vkarpov15 @hasezoey @AbdelrahmanHafez