Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schemaoptions.d.ts): add option "overwriteModels" as a schema option #12817

Merged
merged 1 commit into from Dec 20, 2022
Merged

fix(schemaoptions.d.ts): add option "overwriteModels" as a schema option #12817

merged 1 commit into from Dec 20, 2022

Conversation

hasezoey
Copy link
Collaborator

Summary

This PR adds the schema option overwriteModels to the types

fixes #12816

@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Dec 20, 2022
vkarpov15
vkarpov15 approved these changes Dec 20, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 6.8.2 milestone Dec 20, 2022
@vkarpov15 vkarpov15 merged commit 7316f1a into Automattic:master Dec 20, 2022
@hasezoey hasezoey deleted the addSchemaOptionOM branch December 21, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

@IslandRhythms IslandRhythms Awaiting requested review from IslandRhythms

Assignees
No one assigned
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Milestone
6.8.2
Development

Successfully merging this pull request may close these issues.

Missing Type definition for overwriteModels:true in schemaOptions
2 participants
@hasezoey @vkarpov15