chore: replace many occurrences of "localhost" with "127.0.0.1" #12811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdelrahmanHafez
approved these changes
Dec 19, 2022
Uzlopak
approved these changes
Dec 19, 2022
vkarpov15
approved these changes
Dec 19, 2022
| @@ -58,7 +58,7 @@ If you'd like to preview your documentation changes, first commit your changes t | |||
| * `npm install` | |||
| * `npm run docs:view` | |||
|
|
|||
| Visit `http://localhost:8089` and you should see the docs with your local changes. Make sure you `npm run docs:clean` before committing, because automated generated files to `docs/*` should **not** be in PRs. | |||
| Visit `http://127.0.0.1:8089` and you should see the docs with your local changes. Make sure you `npm run docs:clean` before committing, because automated generated files to `docs/*` should **not** be in PRs. | |||
There was a problem hiding this comment.
This one isn't strictly necessary because Node !== browser. But shouldn't be a problem.
There was a problem hiding this comment.
i saw this in the mass replace and wanted to keep it just in case a browser also decides to change that meaning and to keep the docs more consistent (or in case it is used as a argument to some node process, like a link checker)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces many occurrences of
localhostwith127.0.0.1Exceptions:
CHANGELOG.mdconnections.mdwhere it is talked about usinglocalhostas a hostnamere #12741