Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS benchmark fails with TypeScript 4.9 #12770

Closed
2 tasks done
vkarpov15 opened this issue Dec 5, 2022 · 1 comment · Fixed by #12838
Closed
2 tasks done

TS benchmark fails with TypeScript 4.9 #12770

vkarpov15 opened this issue Dec 5, 2022 · 1 comment · Fixed by #12838
Milestone

Comments

@vkarpov15
Copy link
Collaborator

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

See #12769 . TS benchmark fails with Current⠀benchmark⠀result⠀268025⠀>⠀100000 locally when using TS 4.9. Looks like 4.9 introduced some serious performance regression 😭

@vkarpov15 vkarpov15 added this to the 6.7.6 milestone Dec 5, 2022
@hasezoey
Copy link
Collaborator

hasezoey commented Dec 6, 2022

i cant even get ts-benchmark to run correctly with typescript 4.9

Base result from 4.8.x
$ ts-benchmark -p ./benchmarks/typescript/simple -f 17/100000 18 29 32
ts-benchmark:
 benchmarks/typescript/simple/index.ts(1,38): error TS2307: Cannot find module 'mongoose' or its corresponding type declarations.



 ⠀<{⠀ts-benchmark⠀result⠀}>⠀⠀
┌────────────────┬─────────┐
│⠀Field⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀│⠀Current⠀│
├────────────────┼─────────┤
│⠀Instantiations⠀│⠀11681⠀⠀⠀│
├────────────────┼─────────┤
│⠀Memory⠀used⠀⠀⠀⠀│⠀135463K⠀│
├────────────────┼─────────┤
│⠀Check⠀time⠀⠀⠀⠀⠀│⠀0.73s⠀⠀⠀│
├────────────────┼─────────┤
│⠀Total⠀time⠀⠀⠀⠀⠀│⠀1.23s⠀⠀⠀│
└────────────────┴─────────┘

ts-benchmark result with 4.9.x:

$ ts-benchmark -p ./benchmarks/typescript/simple -f 17/100000 18 29 32
ts-benchmark:
 benchmarks/typescript/simple/index.ts(1,38): error TS2307: Cannot find module 'mongoose' or its corresponding type declarations.



 ⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀<{⠀ts-benchmark⠀result⠀}>⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀
┌────────────────┬───────────┬─────────┬─────────────────────────────────────────────┐
│⠀Field⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀│⠀Current⠀⠀⠀│⠀Succeed⠀│⠀Failure⠀details⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀│
├────────────────┼───────────┼─────────┼─────────────────────────────────────────────┤
│⠀Instantiations⠀│⠀undefined⠀│⠀⠀⠀⠀⛌⠀⠀⠀⠀│⠀Current⠀benchmark⠀result⠀undefined⠀>⠀100000⠀│
├────────────────┼───────────┼─────────┼─────────────────────────────────────────────┤
│⠀Memory⠀used⠀⠀⠀⠀│⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀│⠀⠀⠀⠀✓⠀⠀⠀⠀│⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀│
├────────────────┼───────────┼─────────┼─────────────────────────────────────────────┤
│⠀Check⠀time⠀⠀⠀⠀⠀│⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀│⠀⠀⠀⠀✓⠀⠀⠀⠀│⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀│
├────────────────┼───────────┼─────────┼─────────────────────────────────────────────┤
│⠀Total⠀time⠀⠀⠀⠀⠀│⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀│⠀⠀⠀⠀✓⠀⠀⠀⠀│⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀│
└────────────────┴───────────┴─────────┴─────────────────────────────────────────────┘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants