New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TS benchmark fails with TypeScript 4.9 #12770
Labels
Milestone
Comments
i cant even get Base result from 4.8.x$ ts-benchmark -p ./benchmarks/typescript/simple -f 17/100000 18 29 32
ts-benchmark:
benchmarks/typescript/simple/index.ts(1,38): error TS2307: Cannot find module 'mongoose' or its corresponding type declarations.
⠀<{⠀ts-benchmark⠀result⠀}>⠀⠀
┌────────────────┬─────────┐
│⠀Field⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀│⠀Current⠀│
├────────────────┼─────────┤
│⠀Instantiations⠀│⠀11681⠀⠀⠀│
├────────────────┼─────────┤
│⠀Memory⠀used⠀⠀⠀⠀│⠀135463K⠀│
├────────────────┼─────────┤
│⠀Check⠀time⠀⠀⠀⠀⠀│⠀0.73s⠀⠀⠀│
├────────────────┼─────────┤
│⠀Total⠀time⠀⠀⠀⠀⠀│⠀1.23s⠀⠀⠀│
└────────────────┴─────────┘ ts-benchmark result with 4.9.x: $ ts-benchmark -p ./benchmarks/typescript/simple -f 17/100000 18 29 32
ts-benchmark:
benchmarks/typescript/simple/index.ts(1,38): error TS2307: Cannot find module 'mongoose' or its corresponding type declarations.
⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀<{⠀ts-benchmark⠀result⠀}>⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀
┌────────────────┬───────────┬─────────┬─────────────────────────────────────────────┐
│⠀Field⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀│⠀Current⠀⠀⠀│⠀Succeed⠀│⠀Failure⠀details⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀│
├────────────────┼───────────┼─────────┼─────────────────────────────────────────────┤
│⠀Instantiations⠀│⠀undefined⠀│⠀⠀⠀⠀⛌⠀⠀⠀⠀│⠀Current⠀benchmark⠀result⠀undefined⠀>⠀100000⠀│
├────────────────┼───────────┼─────────┼─────────────────────────────────────────────┤
│⠀Memory⠀used⠀⠀⠀⠀│⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀│⠀⠀⠀⠀✓⠀⠀⠀⠀│⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀│
├────────────────┼───────────┼─────────┼─────────────────────────────────────────────┤
│⠀Check⠀time⠀⠀⠀⠀⠀│⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀│⠀⠀⠀⠀✓⠀⠀⠀⠀│⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀│
├────────────────┼───────────┼─────────┼─────────────────────────────────────────────┤
│⠀Total⠀time⠀⠀⠀⠀⠀│⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀│⠀⠀⠀⠀✓⠀⠀⠀⠀│⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀│
└────────────────┴───────────┴─────────┴─────────────────────────────────────────────┘
|
vkarpov15
added a commit
that referenced
this issue
Dec 26, 2022
vkarpov15
added a commit
that referenced
this issue
Dec 27, 2022
vkarpov15
added a commit
that referenced
this issue
Dec 27, 2022
vkarpov15
added a commit
that referenced
this issue
Dec 28, 2022
chore: fix typescript benchmarks by removing ts-benchmark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
Issue
See #12769 . TS benchmark fails with
Current⠀benchmark⠀result⠀268025⠀>⠀100000
locally when using TS 4.9. Looks like 4.9 introduced some serious performance regression 😭The text was updated successfully, but these errors were encountered: