doc fixes #12738
Merged
doc fixes #12738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
vkarpov15
requested changes
Nov 29, 2022
test/docs/validation.test.js
Outdated
| @@ -502,6 +502,8 @@ describe('validation docs', function() { | |||
| // When running in `validate()` or `validateSync()`, the | |||
| // validator can access the document using `this`. | |||
| // Does **not** work with update validators. | |||
| // use this.get('name') to prevent this error | |||
| // if (this.name === undefined) this.name = this.get('name') | |||
There was a problem hiding this comment.
No need for the line 506 comment. Just make line 507 use this.get('name').toLowerCase()
There was a problem hiding this comment.
I'll need to remove the assertion at the bottom then with the comments since it won't happen anymore if thats good with you.
There was a problem hiding this comment.
Yeah that's fine. We should show the approach that works rather than the approach that doesn't :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.