Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): handle deselecting _id when another field has schema-level select: false #12736

Merged
merged 4 commits into from Nov 30, 2022
Merged

fix(query): handle deselecting _id when another field has schema-level select: false #12736

merged 4 commits into from Nov 30, 2022
+22 −6

Conversation

vkarpov15
Copy link
Collaborator

Fix #12670

Summary

#12670 is a fairly clear bug, thankfully with a quick fix.

Examples

@IslandRhythms
Copy link
Collaborator

LGTM

AbdelrahmanHafez
AbdelrahmanHafez approved these changes Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

hasezoey
hasezoey approved these changes Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@hasezoey hasezoey left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is there already a test for mongodb < 5 to check for that error that it still gets triggered?

@vkarpov15 vkarpov15 merged commit f954a71 into master Nov 30, 2022
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-12670 branch November 30, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez approved these changes

@IslandRhythms IslandRhythms Awaiting requested review from IslandRhythms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@vkarpov15 @IslandRhythms @hasezoey @AbdelrahmanHafez