Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongoose's npm package bundles 6.6.1 package into current version #12725

Closed
2 tasks done
hasezoey opened this issue Nov 26, 2022 · 2 comments · Fixed by #12726
Closed
2 tasks done

Mongoose's npm package bundles 6.6.1 package into current version #12725

hasezoey opened this issue Nov 26, 2022 · 2 comments · Fixed by #12726
Labels
developer-experience This issue improves error messages, debugging, or reporting
Milestone

Comments

@hasezoey
Copy link
Collaborator

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the bug has not already been reported

Mongoose version

6.6.3

Node.js version

none

MongoDB server version

none

Typescript version (if applicable)

none

Description

I have noticed that since mongoose 6.6.3, there is a extra 6.6.1 tgz bundle included in the shipped package, about doubling the size of the package without being of any (to me visible) use

screenshot of 6.6.3

Steps to Reproduce

look at:

Expected Behavior

no extra bundled package

@hasezoey hasezoey added the developer-experience This issue improves error messages, debugging, or reporting label Nov 26, 2022
@hasezoey hasezoey added this to the 6.7.4 milestone Nov 26, 2022
@Uzlopak
Copy link
Collaborator

Uzlopak commented Nov 26, 2022

I assume @vkarpov15 packed locally 6.6.1 for testing and forget to delete it.
We should extend .npmignore to cover .tgz files.

@vkarpov15
Copy link
Collaborator

I'm very sorry about this one. I had a tarball that I was using for testing from npm pack that got published. Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience This issue improves error messages, debugging, or reporting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants