Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting debug on a per-connection basis #12700

Closed
2 tasks done
vkarpov15 opened this issue Nov 17, 2022 · 3 comments · Fixed by #12704
Closed
2 tasks done

Allow setting debug on a per-connection basis #12700

vkarpov15 opened this issue Nov 17, 2022 · 3 comments · Fixed by #12704
Assignees
@IslandRhythms
Labels
enhancement This issue is a user-facing general improvement that doesn't fix a bug or add a new feature
Milestone
6.8

Comments

@vkarpov15
Copy link
Collaborator

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

Right now you can only enable/disable debugging globally. Would be great to do conn.set('debug', true) to just enable debugging for a certain connection.
@vkarpov15 vkarpov15 added the enhancement This issue is a user-facing general improvement that doesn't fix a bug or add a new feature label Nov 17, 2022
@vkarpov15 vkarpov15 added this to the 6.8 milestone Nov 17, 2022
@lpizzinidev
Copy link
Contributor

lpizzinidev commented Nov 18, 2022 •
edited

@vkarpov15
Hi ✋ I've prepared a working implementation addressing this feature request but I saw later that it was already assigned 😅
Can I submit it anyway or should I let @IslandRhythms do the work?

@IslandRhythms
Copy link
Collaborator

@lpizzinidev if its in a state where its working, go ahead an open a PR. We'll review it and if its up to snuff we'll merge it. If not, I'll work on it.

@vkarpov15
Copy link
Collaborator Author

@lpizzinidev feel free to submit your PR 👍

lpizzinidev added a commit to lpizzinidev/mongoose that referenced this issue Nov 19, 2022
@lpizzinidev
feat(debug): allow setting debug on a per-connection basis
1a45ec9 
fix Automattic#12700
@lpizzinidev lpizzinidev mentioned this issue Nov 19, 2022
Merged
lpizzinidev added a commit to lpizzinidev/mongoose that referenced this issue Nov 22, 2022
@lpizzinidev
feat(debug): allow setting debug on a per-connection basis
5839c5e 
fix Automattic#12700
vkarpov15 added a commit that referenced this issue Nov 25, 2022
@vkarpov15
Merge pull request #12704 from lpizzinidev/gh-12700
c4b3fff 
feat(debug): allow setting debug on a per-connection basis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IslandRhythms IslandRhythms

Labels
enhancement This issue is a user-facing general improvement that doesn't fix a bug or add a new feature
Projects
None yet
Milestone
6.8
Development

Successfully merging a pull request may close this issue.

feat(debug): allow setting debug on a per-connection basis lpizzinidev/mongoose
3 participants
@vkarpov15 @lpizzinidev @IslandRhythms