Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(document): explain that $isNew is false in post('save') hooks #12685

Merged
merged 2 commits into from Nov 13, 2022
Merged

docs(document): explain that $isNew is false in post('save') hooks #12685

merged 2 commits into from Nov 13, 2022

Conversation

vkarpov15
Copy link
Collaborator

Fix #11990

Summary

Docs need to explain that $isNew is false in post('save') hooks, this question has come up a few times.

Examples

hasezoey
hasezoey approved these changes Nov 13, 2022
View reviewed changes
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though a lint fix should be run before merging

@vkarpov15 vkarpov15 merged commit c77dd1b into master Nov 13, 2022
@hasezoey hasezoey deleted the vkarpov15/gh-11990 branch November 14, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When and under what conditions Document.prototype.isNew returns true?
2 participants
@vkarpov15 @hasezoey