fix(document): handle setting array to itself after saving and pushing a new value #12672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12656
Summary
We added some tracking of what the "saved state" of a document is in #9396 and #10773, but #12656 pointed out that we're not actually storing this saved state correctly when the first operation is a
push(). Thankfully, #11644 makes this a bit easier: we can copy the state inmarkModified().Hopefully this is all we need, but we may want to consider tracking
savedStateby just cloning the document when the document is saved or loaded. That is easier from an implementation perspective, but bad from a performance perspective. I would prefer to not have to do that.Examples