Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): correct handling for model<any> #12659

Merged
merged 2 commits into from Nov 7, 2022
Merged

Conversation

vkarpov15
Copy link
Collaborator

Fix #12573

Summary

model<any>() currently returns a model with just an _id property, which is very strange. This PR fixes that.

Examples

Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/types/models.test.ts Show resolved Hide resolved
@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Nov 5, 2022
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

Co-authored-by: hasezoey <hasezoey@gmail.com>
@vkarpov15 vkarpov15 merged commit 5280b0c into master Nov 7, 2022
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-12573 branch November 7, 2022 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TS] model, new Model, Document and HydratedDocument: DocType typing inconsistencies
3 participants